From Code to Community: Sponsoring The Perl and Raku Conference 2025 Learn more

ELLIOTJS / Perl-Critic-1.083_003 / lib / Perl / Critic / Policy / Subroutines / ProhibitNestedSubs.pm 

            

              
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
—
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114

              
##############################################################################
#      $URL: http://perlcritic.tigris.org/svn/perlcritic/trunk/Perl-Critic/lib/Perl/Critic/Policy/Subroutines/ProhibitNestedSubs.pm $
#     $Date: 2008-05-17 20:03:55 -0500 (Sat, 17 May 2008) $
#   $Author: clonezone $
# $Revision: 2349 $
##############################################################################
package Perl::Critic::Policy::Subroutines::ProhibitNestedSubs;
use strict;
use warnings;
use Readonly;
use Perl::Critic::Utils qw{ :severities };
use base 'Perl::Critic::Policy';
our $VERSION = '1.083_003';
#-----------------------------------------------------------------------------
Readonly::Scalar my $DESC => q{Nested named subroutine};
Readonly::Scalar my $EXPL =>
    q{Declaring a named sub inside another named sub does not prevent the }
        . q{inner sub from being global.};
#-----------------------------------------------------------------------------
sub supported_parameters { return ()                    }
sub default_severity     { return $SEVERITY_HIGHEST     }
sub default_themes       { return qw(core bugs)         }
sub applies_to           { return 'PPI::Statement::Sub' }
#-----------------------------------------------------------------------------
sub violates {
    my ($self, $elem, $doc) = @_;
    my $inner = $elem->find_first('PPI::Statement::Sub');
    return if not $inner;
    # Must be a violation...
    return $self->violation($DESC, $EXPL, $inner);
}
1;
__END__
#-----------------------------------------------------------------------------
=pod
=for stopwords RJBS SIGNES
=head1 NAME
Perl::Critic::Policy::Subroutines::ProhibitNestedSubs - Too many arguments.
=head1 AFFILIATION
This Policy is part of the core L<Perl::Critic> distribution.
=head1 DESCRIPTION
B<Attention would-be clever Perl writers (including Younger RJBS):>
This does not do what you think:
  sub do_something {
      ...
      sub do_subprocess {
          ...
      }
      ...
  }
C<do_subprocess()> is global, despite where it is declared.
Either write your subs without nesting or use anonymous code
references.
=head1 CONFIGURATION
This Policy is not configurable except for the standard options.
=head1 NOTE
Originally part of L<Perl::Critic::Tics>.
=head1 AUTHOR
Ricardo SIGNES <rjbs@cpan.org>
=head1 COPYRIGHT
Copyright (c) 2007-2008 Ricardo SIGNES.
This program is free software; you can redistribute it and/or modify it under
the same terms as Perl itself.
=cut
# Local Variables:
#   mode: cperl
#   cperl-indent-level: 4
#   fill-column: 78
#   indent-tabs-mode: nil
#   c-indentation-style: bsd
# End:
# ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :