—##############################################################################
# $Date: 2009-01-18 17:32:26 -0600 (Sun, 18 Jan 2009) $
# $Author: clonezone $
# $Revision: 3007 $
##############################################################################
use
5.006001;
use
strict;
use
warnings;
use
Readonly;
our
$VERSION
=
'1.095_001'
;
#-----------------------------------------------------------------------------
Readonly::Scalar
my
$DESC
=>
q{Multiple "package" declarations}
;
Readonly::Scalar
my
$EXPL
=>
q{Limit to one per file}
;
#-----------------------------------------------------------------------------
sub
supported_parameters {
return
() }
sub
default_severity {
return
$SEVERITY_HIGH
}
sub
default_themes {
return
qw( core bugs )
}
sub
applies_to {
return
'PPI::Document'
}
#-----------------------------------------------------------------------------
sub
violates {
my
(
$self
,
$elem
,
$doc
) =
@_
;
my
$nodes_ref
=
$doc
->find(
'PPI::Statement::Package'
);
return
if
!
$nodes_ref
;
my
@matches
= @{
$nodes_ref
} > 1 ? @{
$nodes_ref
}[ 1 .. $
#{$nodes_ref} ] :();
return
map
{
$self
->violation(
$DESC
,
$EXPL
,
$_
)}
@matches
;
}
1;
__END__
#-----------------------------------------------------------------------------
=pod
=head1 NAME
Perl::Critic::Policy::Modules::ProhibitMultiplePackages - Put packages (especially subclasses) in separate files.
=head1 AFFILIATION
This Policy is part of the core L<Perl::Critic|Perl::Critic>
distribution.
=head1 DESCRIPTION
Conway doesn't specifically mention this, but I find it annoying when
there are multiple packages in the same file. When searching for
methods or keywords in your editor, it makes it hard to find the right
chunk of code, especially if each package is a subclass of the same
base.
=head1 CONFIGURATION
This Policy is not configurable except for the standard options.
=head1 AUTHOR
Jeffrey Ryan Thalhammer <thaljef@cpan.org>
=head1 COPYRIGHT
Copyright (c) 2005-2009 Jeffrey Ryan Thalhammer. All rights reserved.
This program is free software; you can redistribute it and/or modify
it under the same terms as Perl itself. The full text of this license
can be found in the LICENSE file included with this module.
=cut
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
# fill-column: 78
# indent-tabs-mode: nil
# c-indentation-style: bsd
# End:
# ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :